Print type of message sent in the verbose log #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the string representation of the message type to the verbose log that notifies about sending a message. Can be useful for troubleshooting issues and it gives better understanding about what the node is doing. Signed-off-by: Yacov Manevich <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: yacovm <[email protected]>
darioush
approved these changes
Aug 29, 2024
dhrubabasu
approved these changes
Aug 29, 2024
StephenButtolph
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the string representation of the message type to the verbose log that notifies about sending a message. Can be useful for troubleshooting issues and it gives better understanding about what the node is doing.
Why this should be merged
Currently it's not possible to understand what type of messages a node is sending from observing the log, even at verbose level, because the log event doesn't contain the type of message.
How this works
Just added the type of message to the log.
How this was tested
No need to test, this is a trivial logging change.