Replace periodic push gossip with pull gossip for block discovery #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
consensus
StephenButtolph
requested review from
abi87,
danlaine and
gyuho
as code owners
|
This PR currently stops periodically gossiping |
StephenButtolph
commented
Nov 24, 2023
| fs.Uint(ConsensusAppConcurrencyKey, constants.DefaultConsensusAppConcurrency, "Maximum number of goroutines to use when handling App messages on a chain") | ||
| fs.Duration(ConsensusShutdownTimeoutKey, constants.DefaultConsensusShutdownTimeout, "Timeout before killing an unresponsive chain") | ||
| fs.Duration(ConsensusGossipAcceptedFrontierFrequencyKey, constants.DefaultAcceptedFrontierGossipFrequency, "Frequency of polling and gossiping accepted frontiers") |
There was a problem hiding this comment.
Felt like this should be next to the related configs
3 tasks
|
Closing in favor of #2367 (which shows an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
See a good write-up on push+pull gossip vs solely push gossip here: ava-labs/coreth#266. In practice, nodes already perform some amount of push+pull gossip (push happens with queries and pull happens with chits). However if a node hasn't learned about a new block, then the node will never start the querying process. Perviously, we relied on other peers in the network to push
Putmessages to the node to learn of new blocks to accept.How this works
This replaces the periodic gossiping of
Putmessages with periodically sendingGetAcceptedFrontiermessages.How this was tested
Putmessages to ensure un-upgraded nodes weren't allowing the node to progress).