set P-chain HRP for tx parsing in offline mode #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobEverly
approved these changes
Mar 26, 2024
Signed-off-by: dhrubabasu <[email protected]>
Signed-off-by: dhrubabasu <[email protected]>
dhrubabasu
force-pushed
the
offline-hrp-fix
branch
from
81685d5
to
49f8d92
Compare
dhrubabasu
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have explicitly set HRP in Online mode only. This results in incorrect addresses being produced as part of parse while running in offline - signing systems.
This PR removes the condition around the hrp setup - as
mapper.GetHRPis not making any network calls.Testing
Ran parse locally in offline mode and correctly parsed a transaction after the change.