Integrate local machine into subnet deploy #2235

sukantoraymond · 2024-10-10T23:18:43Z

Why this should be merged

Integrates using local machine as bootstrap validator into subnet deploy command.

How this works

// create the local node connected to etna
go run main.go node local start --etna-devnet --avalanchego-path <AVALANCHEGO_PATH>

// create a blockchain conf
go run main.go blockchain create

// create subnet+blockchain+convert on the blokchain
go run main.go blockchain deploy --cluster

How this was tested

./bin/avalanche subnet deploy will have to achieve L1 set up with local machine as sole bootstrap validator in Etna Devnet

How is this documented

NA

sukantoraymond · 2024-10-10T23:21:51Z

cmd/blockchaincmd/deploy.go

-			aggregatorExtraPeerEndpoints, err := GetAggregatorExtraPeerEndpoints(network)
+
+			// TODO: replace wait below wiht check for healhty in local machine
+			time.Sleep(70 * time.Second)


will have to change this

Signed-off-by: sukantoraymond <[email protected]>

arturrez · 2024-10-14T18:56:24Z

cmd/blockchaincmd/deploy.go

+	}
+
+	if useLocalMachine {
+		bootstrapEndpoints = []string{"http://127.0.0.1:9650"}


this might be tricky to assume this endpoint as port can be not 9650 but rather dynamic
cc @felipemadero

maybe we should ask user for the endpoint and not yes/no for local machine.
we can hint that it can be 127.0.0.1:9650 for the local machine

I see now. After the previous question, a Start should be made and from that, the endpoint
can be obtained from the anr itself, not need to assume anything.
This is not related to the flag useLocalMachine. This relates to the local cluster that exists previous
to the deploy. The best way should be to check the network, which should be a local cluster,
in that case take the endpoint from anr.

Probably for another PR. Make an issue for this and keep current static assignment.

arturrez · 2024-10-14T19:02:06Z

pkg/node/helper.go

+	if exists, err := CheckClusterExists(app, clusterName); err != nil || !exists {
+		return nil, fmt.Errorf("cluster %q not found", clusterName)
+	}
+	clustersConfig, err := app.LoadClustersConfig()


nit: use

clusterConfig, err := app.GetClusterConfig(clusterName) if err != nil { return err } ``` and `clusterConfig.Nodes` instead

felipemadero · 2024-10-14T20:45:11Z

pkg/subnet/helpers.go

 )

+var errIllegalNameCharacter = errors.New(


this is just copying from refactoring part.

felipemadero · 2024-10-14T20:47:29Z

cmd/blockchaincmd/deploy.go

+	ux.Logger.PrintToUser("You can use your local machine as a bootstrap validator on the blockchain")
+	ux.Logger.PrintToUser("This means that you don't have to to set up a remote server on a cloud service (e.g. AWS / GCP) to be a validator on the blockchain.")
+
+	useLocalMachine, err := app.Prompt.CaptureYesNo("Do you want to use your local machine as a bootstrap validator?")


flag to avoid question for this and just proceed

felipemadero · 2024-10-14T20:47:44Z

cmd/blockchaincmd/deploy.go

@@ -464,6 +466,18 @@ func deployBlockchain(cmd *cobra.Command, args []string) error {
 		return PrintSubnetInfo(blockchainName, true)
 	}

+	ux.Logger.PrintToUser("You can use your local machine as a bootstrap validator on the blockchain")


also this to be guarded by a flag

felipemadero · 2024-10-14T20:48:33Z

cmd/blockchaincmd/deploy.go

@@ -464,6 +466,18 @@ func deployBlockchain(cmd *cobra.Command, args []string) error {
 		return PrintSubnetInfo(blockchainName, true)
 	}

+	ux.Logger.PrintToUser("You can use your local machine as a bootstrap validator on the blockchain")
+	ux.Logger.PrintToUser("This means that you don't have to to set up a remote server on a cloud service (e.g. AWS / GCP) to be a validator on the blockchain.")


probably we want to explain more here? like this is temporary bootstrap validator

Its not temporary if user wants to leave it the node indefinitely as validator

felipemadero · 2024-10-14T20:52:41Z

cmd/blockchaincmd/deploy.go

+	}
+
+	if useLocalMachine {
+		bootstrapEndpoints = []string{"http://127.0.0.1:9650"}


I see now. After the previous question, a Start should be made and from that, the endpoint
can be obtained from the anr itself, not need to assume anything.
This is not related to the flag useLocalMachine. This relates to the local cluster that exists previous
to the deploy. The best way should be to check the network, which should be a local cluster,
in that case take the endpoint from anr.

felipemadero · 2024-10-14T20:53:22Z

cmd/blockchaincmd/deploy.go

+	}
+
+	if useLocalMachine {
+		bootstrapEndpoints = []string{"http://127.0.0.1:9650"}


Probably for another PR. Make an issue for this and keep current static assignment.

felipemadero · 2024-10-14T20:54:03Z

cmd/blockchaincmd/deploy.go

-				chainSpec,
-			)
-			if err != nil {
+		clusterName, err := node.GetClusterNameFromList(app)


The cluster name to be taken from the input network itself IMO

which should be a cluster

models.Networks has ClusterName

better to do it when integrating local node start

felipemadero · 2024-10-14T21:00:33Z

cmd/nodecmd/local.go

@@ -415,14 +416,17 @@ func localStopNode(_ *cobra.Command, _ []string) error {
 func localDestroyNode(_ *cobra.Command, args []string) error {
 	clusterName := args[0]

-	localStopNode(nil, nil)
+	if err := localStopNode(nil, nil); err != nil {
+		return fmt.Errorf("failed to destroy local node: %w", err)


node can be already stopped. for the moment on ignore the error or verify is the node is already stopped,
we want to continue removing all the directorioes that is the reason the error is ignored

just need to make sure this passes lint. removed err

felipemadero · 2024-10-14T21:02:38Z

cmd/nodecmd/local.go

-	}
-	ux.Logger.GreenCheckmarkToUser("%s successfully tracking %s", clusterName, blockchainName)
-	return nil
+	return node.TrackSubnetWithLocalMachine(app, clusterName, blockchainName)


I am not sure it is the moment to move this to node pgk. we keep a part of logic here and a part in node.
also, maybe node is not the final dest package.

felipemadero · 2024-10-14T21:04:35Z

pkg/node/helper.go

@@ -0,0 +1,298 @@
+// Copyright (C) 2022, Ava Labs, Inc. All rights reserved.
+// See the file LICENSE for licensing terms.
+package node


this is for another PR?

anyway, no problem keeping here

Signed-off-by: sukantoraymond <[email protected]>

sukantoraymond added 3 commits October 10, 2024 18:43

one command

7175e30

1 command sync local

151e1a9

1 command

32ef65c

sukantoraymond requested a review from a team as a code owner October 10, 2024 23:18

sukantoraymond requested a review from arturrez October 10, 2024 23:18

sukantoraymond changed the base branch from main to node-create-local October 10, 2024 23:19

fix lint

0e7067c

sukantoraymond commented Oct 10, 2024

View reviewed changes

sukantoraymond added 4 commits October 14, 2024 13:59

Merge branch 'node-create-local' into integrate-local-devnet

23a76bc

Signed-off-by: sukantoraymond <[email protected]>

wait for healthy local

8b7f331

wait for healthy local

6614449

fix lint

6217d99

arturrez reviewed Oct 14, 2024

View reviewed changes

arturrez approved these changes Oct 14, 2024

View reviewed changes

felipemadero reviewed Oct 14, 2024

View reviewed changes

sukantoraymond added 6 commits October 14, 2024 17:58

address comments

54479df

remove err

3dfad06

Merge branch 'node-create-local' into integrate-local-devnet

084018f

Merge branch 'node-create-local' into integrate-local-devnet

50986b7

Signed-off-by: sukantoraymond <[email protected]>

fix merge

2c56e09

update sidecar legacy

84e8ab5

sukantoraymond closed this Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate local machine into subnet deploy #2235

Integrate local machine into subnet deploy #2235

sukantoraymond commented Oct 10, 2024 •

edited

Loading

sukantoraymond Oct 10, 2024

arturrez Oct 14, 2024

arturrez Oct 14, 2024

felipemadero Oct 14, 2024

felipemadero Oct 14, 2024

sukantoraymond Oct 14, 2024

arturrez Oct 14, 2024

felipemadero Oct 14, 2024

sukantoraymond Oct 14, 2024

felipemadero Oct 14, 2024

sukantoraymond Oct 14, 2024

felipemadero Oct 14, 2024

sukantoraymond Oct 14, 2024

felipemadero Oct 14, 2024

sukantoraymond Oct 14, 2024

felipemadero Oct 14, 2024

felipemadero Oct 14, 2024

felipemadero Oct 14, 2024

felipemadero Oct 14, 2024

arturrez Oct 14, 2024

sukantoraymond Oct 14, 2024

sukantoraymond Oct 14, 2024

felipemadero Oct 14, 2024

sukantoraymond Oct 14, 2024

sukantoraymond Oct 14, 2024

felipemadero Oct 14, 2024

felipemadero Oct 14, 2024

felipemadero Oct 14, 2024

Integrate local machine into subnet deploy #2235

Integrate local machine into subnet deploy #2235

Conversation

sukantoraymond commented Oct 10, 2024 • edited Loading

Why this should be merged

How this works

How this was tested

How is this documented

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sukantoraymond commented Oct 10, 2024 •

edited

Loading