Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added more ROS 2 SLAM Implementations in alphabetical order #629

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

horverno
Copy link
Contributor

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@horverno horverno changed the title added more ROS 2 SLAM Implementations in alphabetical order docs: added more ROS 2 SLAM Implementations in alphabetical order Nov 25, 2024
@horverno
Copy link
Contributor Author

@TaikiYamada4
thanks for the previous comments, i have to open a new PR instead of #623 because of missing Signed-off-by commits

What i have done:

  • Modified SLAM methods in alphabetical order
  • Have commits signed (Signed-off-by)

@TaikiYamada4 TaikiYamada4 added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 26, 2024
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the links are valid and ordered correctly.
Thanks for your contribution!!
LGTM 👍

@TaikiYamada4 TaikiYamada4 merged commit 6b3260e into autowarefoundation:main Nov 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants