Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add autoware prefix to the vehicle_velocity_converter #618

Conversation

a-maumau
Copy link
Contributor

Description

This PR will add the autoware prefix to vehicle_velocity_converter due to the changes in autowarefoundation/autoware.universe#8967 .

This PR should merged after autowarefoundation/autoware.universe#8967 get merged.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: a-maumau <[email protected]>
Copy link

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo
Copy link
Contributor

@a-maumau please fix conflicts

@a-maumau
Copy link
Contributor Author

@YamatoAndo I resolved the conflict.

@shmpwk shmpwk merged commit d5a4a6e into autowarefoundation:main Nov 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants