Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep session settings #130

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Aug 16, 2024

Description

Keep user settings for other sessions.

Currently tracks:
image

Related links

Tests performed

Tested with binary build.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mozhoku mozhoku self-assigned this Aug 16, 2024
@mozhoku mozhoku added the type:new-feature New functionalities or additions, feature requests. label Aug 16, 2024
@mozhoku mozhoku force-pushed the feat/keep-session-settings branch from dfe7baa to cabe36e Compare August 16, 2024 15:38
@mozhoku mozhoku requested a review from Aysenayilmaz August 16, 2024 15:53
@mozhoku mozhoku marked this pull request as ready for review August 16, 2024 15:53
Copy link
Collaborator

@Aysenayilmaz Aysenayilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for work !

Signed-off-by: Alptuğ Cırıt <[email protected]>
Signed-off-by: Alptuğ Cırıt <[email protected]>
@mozhoku mozhoku force-pushed the feat/keep-session-settings branch from 4f32d9d to 59497f8 Compare August 19, 2024 09:00
@mozhoku mozhoku merged commit aea30f0 into autowarefoundation:main Aug 19, 2024
6 of 7 checks passed
@mozhoku mozhoku deleted the feat/keep-session-settings branch August 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:new-feature New functionalities or additions, feature requests.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants