Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balloon_check: fix the inconsistent comparison #4220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiagao
Copy link
Contributor

@xiagao xiagao commented Nov 27, 2024

When balloon memory to a big value, it means balloon deflation, in guest the in use memory would be reduced;
while balloon memory to a small value, it means balloon inflation, in guest the in use memory would be increased.

So the calculation method should be updated.
ID: 1316

When balloon memory to a big value, it means balloon deflation,
in guest the in use memory would be reduced;
while balloon memory to a small value, it means balloon inflation,
in guest the in use memory would be increased.

So the calculation method should be updated.

Signed-off-by: Xiaoling Gao <[email protected]>
@xiagao
Copy link
Contributor Author

xiagao commented Nov 27, 2024

@mcasquer Could you help review the balloon relevant patch?

@mcasquer
Copy link
Contributor

Hello @xiagao I tirggered the balloon_check tests with RHEL 9.6.0 and Win2025 guests, I faced a couple of failures in the latter, but I would say them aren't caused by this patch:

 (01/22) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.balloon_check.balloon_evict.balloon-migrate.q35: STARTED
 (01/22) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.balloon_check.balloon_evict.balloon-migrate.q35: PASS (174.58 s)
...
 (13/22) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_check.balloon_evict.balloon-reboot.q35: ERROR: Timeout expired while waiting for shell command to complete: 'systeminfo'    (output: '') (825.99 s)
...
 (14/22) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_check.balloon_evict.balloon-shutdown.q35:ERROR: 'NoneType' object has no attribute 'group' (338.03 s)
...
 (15/22) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.balloon_check.balloon_evict.balloon-stop_continue.q35: ERROR: Login timeout expired    (output: "exceeded 360.0 s timeout, last failure: Login timeout expired    (output: '')") (614.05 s)
 ...

If you want to debug them I can provide the logs internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants