Add gateway to snapshot builds in CI #3256
Open
+113
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
nazar-pc
reviewed
Nov 26, 2024
| @@ -104,7 +107,6 @@ jobs: | |||
| cd executables | |||
| IMAGE="${{ fromJSON(steps.meta.outputs.json).tags[0] }}" | |||
| ARTIFACT="${{ matrix.build.base-artifact }}" | |||
There was a problem hiding this comment.
It set off my editor's trailing spaces auto-formatting.
There was a problem hiding this comment.
Removing trailing spaces is good, but this one got the whole line itself removed. It is fine.
teor2345
force-pushed
the
gateway-docker
branch
from
0db2de7
to
222e853
Compare
teor2345
commented
Nov 26, 2024
| @@ -104,7 +107,6 @@ jobs: | |||
| cd executables | |||
| IMAGE="${{ fromJSON(steps.meta.outputs.json).tags[0] }}" | |||
| ARTIFACT="${{ matrix.build.base-artifact }}" | |||
There was a problem hiding this comment.
It set off my editor's trailing spaces auto-formatting.
nazar-pc
approved these changes
Nov 26, 2024
| @@ -104,7 +107,6 @@ jobs: | |||
| cd executables | |||
| IMAGE="${{ fromJSON(steps.meta.outputs.json).tags[0] }}" | |||
| ARTIFACT="${{ matrix.build.base-artifact }}" | |||
There was a problem hiding this comment.
Removing trailing spaces is good, but this one got the whole line itself removed. It is fine.
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
subspace-gatewayto snapshot builds.Test build here (including #3257): https://github.com/autonomys/subspace/actions/runs/12022336058
Code contributor checklist: