Slightly improved tests for loadRange method #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is more a question then a suggestion.
The question: should we care about an order in which
StorageAdapterInterface.loadRange
returns data?When I utilized
expect.arrayContaining
in this commit bijela-gora@3238d7a to automerge-repo I'm sure I didn't consider that. Now, I'm not even sure why I used that asymmetric matcher. Theexpect.arrayContaining
does not care about an order of elements inside arrays:I noticed that a day ago when I was trying to make a storage adapter based on
node:sqlite
. For some reasonsbetter-sqlite3
andnode:sqlite
for the same SQL statement returns results ordered differently. I tested that with latest version of better-sqlite3 and with latest Node.js because latest versions uses the same SQLite version