Add API support for transaction metadata on WriteRels and DeleteRels #2084
+183
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
write-delete-metadata
branch
from
5b93474
to
1f6dffb
Compare
tstirrat15
previously approved these changes
Oct 1, 2024
| @@ -42,6 +43,8 @@ var writeUpdateCounter = promauto.NewHistogramVec(prometheus.HistogramOpts{ | |||
| Buckets: []float64{0, 1, 2, 5, 10, 15, 25, 50, 100, 250, 500, 1000}, | |||
| }, []string{"kind"}) | |||
|
|
|||
| const MaximumTransactionMetadataSize = 65000 // bytes. Limited by the BLOB size used in MySQL driver | |||
There was a problem hiding this comment.
Is it worth making this datastore-specific? Or will we burn that bridge when we get to it?
There was a problem hiding this comment.
I'd rather set it to the low amount and reevaluate in the future if need be. "65K should be enough for anyone!"
| } | ||
|
|
||
| if len(b) > MaximumTransactionMetadataSize { | ||
| return NewTransactionMetadataTooLargeErr(len(b), MaximumTransactionMetadataSize) |
There was a problem hiding this comment.
Are we guaranteed that the client encoding will match the JSON encoding? i.e. will the size that that the client sees on their machine match what we're validating against here?
There was a problem hiding this comment.
No; this is a rough estimate but since the drivers store JSON too, it should be sufficient
josephschorr
force-pushed
the
write-delete-metadata
branch
from
1f6dffb
to
83f4bf2
Compare
tstirrat15
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.