Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upsert overlap #1238

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

upsert overlap #1238

wants to merge 10 commits into from

Conversation

ecordell
Copy link
Contributor

@ecordell ecordell commented Mar 31, 2023

This uses an UPSERT to create transaction overlap in CRDB. In benchmarks it appears to be slightly faster than the INSERT ... ON CONFLICT

@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Mar 31, 2023
jakedt and others added 10 commits April 3, 2023 12:26
This changes the default for OTEL sample ratio to
be 1% instead of 20%.

Our experience running SpiceDB in production has
made it clear that 20% is far too large of a
default sample ratio for most deployments.
Appeared to be a race condition

Stress output:

$ stress ./server.test -test.run=TestServerGracefulTermination -test.cpu=2 -test.timeout=5s
5s: 951 runs so far, 0 failures
10s: 1992 runs so far, 0 failures
15s: 3071 runs so far, 0 failures
20s: 4134 runs so far, 0 failures
25s: 5159 runs so far, 0 failures
30s: 6215 runs so far, 0 failures

Fixes authzed#1236
Fix flakiness of graceful termination test
Also unblocks moving forward on gRPC

Fixes authzed#1247
@github-actions github-actions bot added area/api http Affects the HTTP Gateway API area/CLI Affects the command line area/dependencies Affects dependencies labels Apr 5, 2023
@ecordell
Copy link
Contributor Author

Recent CRDB release notes make it sound as though SELECT FOR UPDATE may work for overlap now - it's worth re-running the tests with new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api http Affects the HTTP Gateway API area/CLI Affects the command line area/datastore Affects the storage system area/dependencies Affects dependencies area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants