Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedicated metrics examples #18

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Dedicated metrics examples #18

merged 2 commits into from
Aug 12, 2024

Conversation

alecmerdler
Copy link
Contributor

Adding some examples of collecting metrics for authzed dedicated

kbrwn and others added 2 commits August 9, 2024 14:42
@kbrwn
init metrics commit
362e37c 
adding some examples of collecting metrics for dedicated
@alecmerdler
fixed yamllint errors
18b4888
@alecmerdler alecmerdler requested a review from a team as a code owner August 12, 2024 15:03
@alecmerdler
Copy link
Contributor Author

@kbrwn I took your commit from #17 and fixed up the linter errors here. Thanks for the contribution!

tstirrat15
tstirrat15 approved these changes Aug 12, 2024
View reviewed changes
Copy link

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecmerdler alecmerdler merged commit b56e4bb into main Aug 12, 2024
4 checks passed
@alecmerdler alecmerdler deleted the dedicated-metrics-examples branch August 12, 2024 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alecmerdler @tstirrat15 @jzelinskie @kbrwn