-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rendering the settings of prompt-screen #1077
base: main
Are you sure you want to change the base?
Add support for rendering the settings of prompt-screen #1077
Conversation
2. Include unit tests, examples and docs 3. Update Go-Auth0's dependent version
StateContext: schema.ImportStatePassthroughContext, | ||
}, | ||
Description: "With this resource, you can Configure the render settings for a specific screen." + | ||
"You can read more about this [here](https://auth0.com/docs/customize/universal-login-pages/.../acul).", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link is not valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have asked the ACUL team to provide the docs link, will update once we get an update.
For time being.. I've added to just replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, make sure to update it before release or remove it.
Computed: true, | ||
ValidateFunc: validation.StringIsJSON, | ||
DiffSuppressFunc: structure.SuppressJsonDiff, | ||
Description: "An array of head tags", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add better description
), | ||
}, | ||
}, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add case for testAccPromptScreenRenderDelete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included
|
||
# Resource: auth0_prompt_screen_renderer | ||
|
||
With this resource, you can Configure the render settings for a specific screen.You can read more about this [here](https://auth0.com/docs/customize/universal-login-pages/.../acul). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to update it before release or remove it.
e2e test recordings are not available |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
- Coverage 89.41% 89.31% -0.10%
==========================================
Files 126 128 +2
Lines 17464 17652 +188
==========================================
+ Hits 15615 15766 +151
- Misses 1309 1335 +26
- Partials 540 551 +11
|
looks like a lint ERROR, please lint the code. |
🔧 Changes
Added new resources and data sources: "auth0_prompt_screen_renderer"
Added relevant expand and flatten rules.
Added relevant test cases for data_source and resource.
Added relevant docs and examples.
Example
📝 Checklist