-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] [feat]: Template for custom timeout based on metadata #24
Merged
edwardsbrentg
merged 8 commits into
auth0:main
from
nelsonmaia:feat-template-timeout-per-metadata
Nov 19, 2024
Merged
[draft] [feat]: Template for custom timeout based on metadata #24
edwardsbrentg
merged 8 commits into
auth0:main
from
nelsonmaia:feat-template-timeout-per-metadata
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggoodman
reviewed
Sep 25, 2024
...and-idle-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/code.js
Outdated
Show resolved
Hide resolved
ggoodman
reviewed
Sep 25, 2024
...le-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/manifest.yaml
Outdated
Show resolved
Hide resolved
ggoodman
reviewed
Sep 25, 2024
...and-idle-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/code.js
Outdated
Show resolved
Hide resolved
@ggoodman Added the new suggestion and some links into the comments of the actions |
That looks good to me. I'm working to find out how we take on these changes before hitting the approve button. |
...le-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/manifest.yaml
Outdated
Show resolved
Hide resolved
...le-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/manifest.yaml
Outdated
Show resolved
Hide resolved
...le-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/manifest.yaml
Outdated
Show resolved
Hide resolved
...le-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/manifest.yaml
Outdated
Show resolved
Hide resolved
@edwardsbrentg @ggoodman I've committed all the suggested changes, would you be able to review it please? |
...le-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/manifest.yaml
Outdated
Show resolved
Hide resolved
...le-timeout-based-on-organization-connection-or-application-metadata-POST_LOGIN/manifest.yaml
Outdated
Show resolved
Hide resolved
edwardsbrentg
previously approved these changes
Nov 1, 2024
nelsonmaia
force-pushed
the
feat-template-timeout-per-metadata
branch
2 times, most recently
from
November 1, 2024 17:12
b38b706
to
dfd19a7
Compare
…notes and the code
…connection-or-application-metadata-POST_LOGIN/code.js Accepting the suggestion Co-authored-by: Geoff Goodman <[email protected]>
…ier documentation
…connection-or-application-metadata-POST_LOGIN/manifest.yaml Fixing the spacing Co-authored-by: Brent Edwards <[email protected]>
nelsonmaia
force-pushed
the
feat-template-timeout-per-metadata
branch
from
November 1, 2024 17:15
dfd19a7
to
889522f
Compare
edwardsbrentg
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made by Nelson Matias, Okta Product Manager
Adding a new Actions template that allow using the new Auth0 feature of setting custom session timeout in Actions.
This action checks for specific metadata created either in organizations, connections or in application and use it to set custom absolute or idle timeout
References
This new Auth0 feature can be used in a easier way https://auth0.com/docs/secure/continuous-session-protection
Testing
Steps to Reproduce
Test 1:
authorize
call again. You should see the user log out.Test 2:
Test 3:
Test 4:
Checklist
main