Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated templates to check cache for token #17

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: Updated templates to check cache for token #17

merged 1 commit into from
Feb 5, 2024

Conversation

jean1880
Copy link
Contributor

@jean1880 jean1880 commented Jan 31, 2024 •
edited
Loading

Changes

  • Updated four templates, to make use of API cache, to check for auth token BEFORE attempting to create a new token. this will reduce the number of times the template attempts to create a new auth0 token, especially when under high loads
  • I described the changes on this PR.

References

Internal bug report

Testing

image

Run without cache:
image

Run with Cache:
image

Checklist

@jean1880 jean1880 requested a review from a team as a code owner January 31, 2024 17:52
@johneke-auth0 johneke-auth0 self-requested a review January 31, 2024 18:42
johneke-auth0
johneke-auth0 requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@johneke-auth0 johneke-auth0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistakenly approved

@jean1880 jean1880 force-pushed the fixes-cache-patch-auth branch 2 times, most recently from b83e8fd to c9dfd45 Compare February 5, 2024 14:43
@jean1880 jean1880 force-pushed the fixes-cache-patch-auth branch 2 times, most recently from b3a5676 to 9ec5da8 Compare February 5, 2024 17:00
@jean1880 jean1880 force-pushed the fixes-cache-patch-auth branch 2 times, most recently from 5bb2be6 to 7f87259 Compare February 5, 2024 18:11
@johneke-auth0 johneke-auth0 self-requested a review February 5, 2024 18:34
@jean1880 jean1880 force-pushed the fixes-cache-patch-auth branch 2 times, most recently from cea56ac to c93522a Compare February 5, 2024 20:28
johneke-auth0
johneke-auth0 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@johneke-auth0 johneke-auth0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some linter errors, otherwise 🚢

@jean1880
fix: Updated templates to check cache for token
e0f98d7 
- Updated four templates, to make use of API cache, to check for auth
  token BEFORE attempting to create a new token. this will reduce the
  number of times the template attempts to create a new auth0 token,
  especially when under high loads
@jean1880 jean1880 merged commit 76016c6 into main Feb 5, 2024
8 checks passed
@jean1880 jean1880 deleted the fixes-cache-patch-auth branch February 5, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johneke-auth0 johneke-auth0 johneke-auth0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jean1880 @johneke-auth0