Add options for location of Response signature in message #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re' method to pass location object containing action & reference properties to enable different Response signature locations
…ponse updated function 'buildSamlResponse' when calling the 'computeSignatu…
|
based on the SAML schema, the signature must be placed after the issuer. I would not add an option for this, I would specify the correct location directly - #42 (comment) Can you add or update a test with this change ? |
need exact version of 'saml' package not 0.12.2 introduced a breaking change to this fork of 'samlp'
added some logging to track bad responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'location' object to the call to 'sig.computeSignature' this allows specifying the reference and action of the Response signature. Without this the location of the Response signature is always appended to the root node per the defaulting logic in xml-crypto\lib\signed-xml.js