SAMLResponse Assertion wrongfully placed at end of XML instead of after issuer #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the test. |
|
With this PR you are changing some behaviour we don't want to change. You are removing the signature prefix and the keyinfo. The correct fix would be to add the location when computing the signature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we could use the signing function we already have containing the fix from #42 to fix the SAMLResponse signing issue. The Signature is now at the end of the XML instead of after the issuer.
#29 also fixes this but introduces some other changes (features) as well. Created this pull request so we can just fix this bug.