refactor: replacing protocol lookup with ternary #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the protocol to be a ternary instead of a lookup. The lookup creates a cached copy of
http.get
andhttps.get
, which means libraries likenock
can't override them unlessnock
is explicitly imported before any application code. This is why it's not failing for the current tests in the repository.Testing
❌ Fails with
Failed to fetch authorization server metadata
because it tries to make a real Api callPasses ✅
This will fail with:
Failed to fetch authorization server metadata
because it tries to make a real Api callChecklist