Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid optional properties on responses where possible #921

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Avoid optional properties on responses where possible #921

merged 2 commits into from
Aug 28, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 24, 2023 •
edited
Loading

Changes

This PR removes a whole lot of optional properties on responses (not request payloads) to improve DX.

Checklist

@frederikprijck frederikprijck requested a review from a team as a code owner August 24, 2023 14:18
@frederikprijck frederikprijck merged commit f695697 into beta Aug 28, 2023
4 checks passed
@frederikprijck frederikprijck deleted the chore/avoid-optionals branch August 28, 2023 08:41
@adamjmcgrath adamjmcgrath mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederikprijck @adamjmcgrath