Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4233] Migrate remaining tests to jest #898

Merged
merged 8 commits into from
Aug 10, 2023
Merged

[SDK-4233] Migrate remaining tests to jest #898

merged 8 commits into from
Aug 10, 2023

Conversation

adamjmcgrath
Copy link
Contributor

Changes

  • 742afaf Migrate remaining tests to jest (using jest-codemods)
  • e8e33ac Add tests to lint and run eslint --fix
  • 5892ca3 Add missing test coverage
    • Apply Query params test
    • Anomaly and keys manager tests
    • Email template manager put
    • CustomDomains update
    • Couple of cases in IDToken Validator

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner August 10, 2023 10:11
@adamjmcgrath adamjmcgrath marked this pull request as draft August 10, 2023 10:14
@adamjmcgrath adamjmcgrath marked this pull request as ready for review August 10, 2023 12:23
@@ -24,10 +24,10 @@ jobs:
command: npm run build
- run:
name: Tests
command: npm run test:ci
command: npm run test:ci -- -- --maxWorkers=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could --maxWorkers be provided in the test:ci script rather than here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure c24a582 👍

@adamjmcgrath adamjmcgrath merged commit 1242f33 into beta Aug 10, 2023
4 checks passed
@adamjmcgrath adamjmcgrath deleted the update-tests branch August 10, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants