Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for setting the external_id parameter #1038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions test/management/jobs.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,33 @@ describe('JobsManager', () => {
});
});

it('should set the `external_id` parameter correctly', (done) => {
nock.cleanAll();
let boundary: string | null = null;
const external_id = 'some_job_correlation_id';

const request = nock(API_URL)
.matchHeader('Content-Type', (header) => {
boundary = `--${header.match(/boundary=([^\n]*)/)?.[1]}`;

return true;
})
.post('/jobs/users-imports', (body) => {
const parts = extractParts(body, boundary);

expect(parts.external_id).toBe(external_id);

return true;
})
.reply(200, {});

jobs.importUsers(Object.assign({}, data, { external_id })).then(() => {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Object.assign instead of spread here for style consistency with other tests in this file.

expect(request.isDone()).toBe(true);

done();
});
});

it('should include the token in the Authorization header', (done) => {
nock.cleanAll();

Expand Down