Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate CI to GtiHub [SDK-4450] #1437

Merged
merged 22 commits into from
Oct 13, 2023
Merged

Conversation

evansims
Copy link
Member

📋 Changes

This pull request replaces our current CircleCI continuous integration suite for auth0-react with a new workflow using GitHub Actions.

📎 References

Please see internal ticket SDK-4450.

🎯 Testing

This pull request replaces our continuous integration suite with one built in GitHub's native Actions ecosystem. It aligns with other migrations taking place across our repositories.

@evansims evansims added the review:small Small review label Sep 18, 2023
@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextjs-auth0 ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 0:21am

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

.github/workflows/publish.yml Show resolved Hide resolved
@evansims
Copy link
Member Author

evansims commented Sep 18, 2023

@adamjmcgrath I am unable to get npm test to work on either the CI migration or my local machine. Been banging my head on it for several hours now without much luck. Could you please take a look into resolving the issue so we can merge this?

@evansims evansims marked this pull request as ready for review September 18, 2023 18:25
@evansims evansims requested a review from a team as a code owner September 18, 2023 18:25
@frederikprijck
Copy link
Member

With @adamjmcgrath being off, I'll look into this.

@evansims
Copy link
Member Author

@frederikprijck Great, thanks. (FWIW, regarding your last commit, it already builds before running tests; see the build job the unit job needs beforehand.)

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@evansims
Copy link
Member Author

evansims commented Sep 25, 2023

@adamjmcgrath All migrated tests appear to be passing successfully with the workflows today. Uncertain why they hadn't worked previously, the error messages were rather confusing and vague.

CircleCI test is also randomly busted, it appears, so doesn't look related to anything to do with the migration.

That being the case, PR is ready for your review. Thanks!

Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evansims - I'm still seeing failed tests even though the "Run Unit Tests" job is reporting as successful

image

Will take a look at the tests when I have some time

@adamjmcgrath
Copy link
Contributor

Unit tests are passing on GH Actions, just need to investigate why Browserstack tests aren't running

@adamjmcgrath adamjmcgrath temporarily deployed to internal October 12, 2023 13:56 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal October 12, 2023 14:29 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal October 12, 2023 14:40 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal October 12, 2023 14:59 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal October 13, 2023 12:12 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal October 13, 2023 12:20 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal October 13, 2023 12:21 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath merged commit 37e334b into main Oct 13, 2023
8 checks passed
@adamjmcgrath adamjmcgrath deleted the test/github-ci-migration branch October 13, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants