Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new Prompts and Screens for Prompt Partial #437

Merged

Conversation

developerkunal
Copy link
Contributor

@developerkunal developerkunal commented Aug 26, 2024

🔧 Changes

  • Added new methods GetPartials and SetPartials for improved prompt partial management.

⚠️ Deprecated

  • The methods ReadPartials, CreatePartials, and UpdatePartials are deprecated. Use GetPartials and SetPartials instead.

📚 References

🔬 Testing

  • Verified GetPartials and SetPartials methods with new unit tests to ensure correct functionality.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (0c331b7) to head (fb83e29).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   95.65%   95.67%   +0.02%     
==========================================
  Files          49       49              
  Lines        8172     8187      +15     
==========================================
+ Hits         7817     7833      +16     
+ Misses        238      237       -1     
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

acwest
acwest previously approved these changes Aug 26, 2024
management/prompt.go Outdated Show resolved Hide resolved
duedares-rvj
duedares-rvj previously approved these changes Sep 2, 2024
duedares-rvj
duedares-rvj previously approved these changes Sep 2, 2024
@developerkunal developerkunal merged commit e31d23f into main Sep 2, 2024
10 checks passed
@developerkunal developerkunal deleted the SDK-4933-Support-new-Prompts-for-Partial-Prompts branch September 2, 2024 15:08
@developerkunal developerkunal mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants