Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Self Service Profiles #431

Merged
merged 13 commits into from
Aug 16, 2024
Merged

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Aug 6, 2024

🔧 Changes

Support for CRUD operations to the Self-Service Profile on Management APIs.

  1. POST /api/v2/self-service-profiles
  2. GET /api/v2/self-service-profiles
  3. GET /api/v2/self-service-profiles/{id}
  4. PATCH /api/v2/self-service-profiles/{id}
  5. DELETE /api/v2/self-service-profiles/{id}
  6. POST /api/v2/self-service-profiles/{id}/sso-ticket

📚 References

Create a self-service profile
Retrieve self-service profiles
Retrieve a self-service profile by id
Update a self-service profile
Delete a self-service profile by id
Create an sso-access ticket to initiate the self service sso flow

🔬 Testing

Added relevant test cases for all the endpoints to ensure functionality is as expected:
All created resources are cleaned up after the assertions are completed.

Management Package

  • TestSelfServiceProfileManager_Create
    Creates a profile and retrieves the same using a get call and validates the ID.
  • TestSelfServiceProfileManager_List
    Lists all the profiles and validates the length, also ensure that the list includes a pre-created placeholder profile.
  • TestSelfServiceProfileManager_Read
    Gets a specific profile against it's ID and validates all attributes for it.
  • TestSelfServiceProfileManager_Update
    Updates an attribute for an existing profile and validates the desired change.
  • TestSelfServiceProfileManager_Delete
    Delete a given profile and validates it's existence using a get call for the delete profile.
  • TestSelfServiceProfileManager_CreateTicket
    Creates a ticket against given configuration and validates the response attributes.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.64%. Comparing base (921144d) to head (e7d0685).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   95.60%   95.64%   +0.04%     
==========================================
  Files          47       48       +1     
  Lines        8006     8081      +75     
==========================================
+ Hits         7654     7729      +75     
  Misses        235      235              
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duedares-rvj duedares-rvj marked this pull request as ready for review August 12, 2024 06:05
@duedares-rvj duedares-rvj requested a review from a team as a code owner August 12, 2024 06:05
@developerkunal developerkunal changed the title Self Service SSO: Added support for relevant APIs Add Support for Self Service Profiles Aug 16, 2024
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@developerkunal developerkunal merged commit ea1459e into main Aug 16, 2024
7 checks passed
@developerkunal developerkunal deleted the SDK-4922/Self-Service-SSO branch August 16, 2024 12:27
@developerkunal developerkunal mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants