-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Self Service Profiles #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 95.60% 95.64% +0.04%
==========================================
Files 47 48 +1
Lines 8006 8081 +75
==========================================
+ Hits 7654 7729 +75
Misses 235 235
Partials 117 117 ☔ View full report in Codecov by Sentry. |
developerkunal
changed the title
Self Service SSO: Added support for relevant APIs
Add Support for Self Service Profiles
Aug 16, 2024
developerkunal
temporarily deployed
to
internal
August 16, 2024 12:05
— with
GitHub Actions
Inactive
developerkunal
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Support for CRUD operations to the Self-Service Profile on Management APIs.
📚 References
Create a self-service profile
Retrieve self-service profiles
Retrieve a self-service profile by id
Update a self-service profile
Delete a self-service profile by id
Create an sso-access ticket to initiate the self service sso flow
🔬 Testing
Added relevant test cases for all the endpoints to ensure functionality is as expected:
All created resources are cleaned up after the assertions are completed.
Management Package
Creates a profile and retrieves the same using a get call and validates the ID.
Lists all the profiles and validates the length, also ensure that the list includes a pre-created placeholder profile.
Gets a specific profile against it's ID and validates all attributes for it.
Updates an attribute for an existing profile and validates the desired change.
Delete a given profile and validates it's existence using a get call for the delete profile.
Creates a ticket against given configuration and validates the response attributes.
📝 Checklist