Fix recording of tests when using a separate authentication api instance #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 95.18% 95.10% -0.08%
==========================================
Files 46 46
Lines 8956 8956
==========================================
- Hits 8525 8518 -7
- Misses 329 334 +5
- Partials 102 104 +2 ☔ View full report in Codecov by Sentry. |
Widcket
reviewed
Dec 4, 2023
CONTRIBUTING.md
Outdated
|
|
||
| Then create a local `.env` file in the `authentication` folder with the following settings: | ||
|
|
||
| * `AUTH0_DOMAIN`: The **Domain** of the M2M app |
There was a problem hiding this comment.
Suggested change
| * `AUTH0_DOMAIN`: The **Domain** of the M2M app | |
| * `AUTH0_DOMAIN`: The **Domain** of the Auth0 tenant |
Widcket
reviewed
Dec 4, 2023
Comment on lines
+34
to
+35
| mgmtClientID = os.Getenv("AUTH0_CLIENT_ID") | ||
| mgmtClientSecret = os.Getenv("AUTH0_CLIENT_SECRET") |
There was a problem hiding this comment.
Should these be AUTH0_MGMT_CLIENT_ID and AUTH0_MGMT_CLIENT_SECRET to more clearly distinguish them from their auth counterparts?
There was a problem hiding this comment.
I'd left these as matching what's used for the management tests to make it easier to reuse them (some folks might opt to set environment variables themselves instead of the .env file)
Widcket
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Improves the coverage of the authentication client when running
make test-e2eand skips tests that ultimately are not testable in that test scenario. Also updates the contributing documentation to help with creating the required applications.📚 References
🔬 Testing
📝 Checklist