Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties to GoogleApps conn #278

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Sep 11, 2023

🔧 Changes

Adding missed connection options for Google Workspace.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (23f8631) 94.73% compared to head (2b36943) 94.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   94.73%   94.74%   +0.01%     
==========================================
  Files          46       46              
  Lines        8790     8815      +25     
==========================================
+ Hits         8327     8352      +25     
  Misses        361      361              
  Partials      102      102              
Files Changed Coverage Δ
management/connection.go 72.50% <ø> (ø)
management/management.gen.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiught sergiught marked this pull request as ready for review September 11, 2023 12:47
@sergiught sergiught requested a review from a team as a code owner September 11, 2023 12:47
@sergiught sergiught merged commit 2289727 into main Sep 12, 2023
4 checks passed
@sergiught sergiught deleted the patch/google-apps-options branch September 12, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants