Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-536: Add pkce and attribute_map settings to OIDC and Okta connections #277

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Sep 7, 2023

🔧 Changes

Add support for https://auth0.com/docs/authenticate/identity-providers/enterprise-identity-providers/configure-pkce-claim-mapping-for-oidc#map-claims-for-oidc-connections on OIDC and Okta connections.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (7818faf) 94.70% compared to head (391c025) 94.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   94.70%   94.73%   +0.02%     
==========================================
  Files          46       46              
  Lines        8746     8790      +44     
==========================================
+ Hits         8283     8327      +44     
  Misses        361      361              
  Partials      102      102              
Files Changed Coverage Δ
management/connection.go 72.50% <ø> (ø)
management/management.gen.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiught sergiught merged commit 23f8631 into main Sep 8, 2023
4 checks passed
@sergiught sergiught deleted the DXCDT-536-oidc-options branch September 8, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants