Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing scope tags to connection options #269

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Add missing scope tags to connection options #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91c61b9
Add missing scope tags to connection options
sergiught Aug 27, 2023
4626383
Add thumbprints to ad connection options
sergiught Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions management/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,8 @@ type ConnectionOptionsAD struct {

UpstreamParams map[string]interface{} `json:"upstream_params,omitempty"`

Thumbprints *[]string `json:"thumbprints,omitempty"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems to have been missed from the AD connection options type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To note also that the SAML conn type has thumbprints defined as []interface{} instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the SAML property was added before the schema repo so we didn't know the type of it?


Certs *[]string `json:"certs,omitempty"`
AgentIP *string `json:"agentIP,omitempty"`
AgentVersion *string `json:"agentVersion,omitempty"`
Expand Down Expand Up @@ -986,8 +988,8 @@ type ConnectionOptionsPingFederate struct {
AgentIP *string `json:"agentIP,omitempty"`
AgentVersion *string `json:"agentVersion,omitempty"`
AgentMode *bool `json:"agentMode,omitempty"`
ExtGroups *bool `json:"ext_groups,omitempty"`
ExtProfile *bool `json:"ext_profile,omitempty"`
ExtGroups *bool `json:"ext_groups,omitempty" scope:"ext_groups"`
ExtProfile *bool `json:"ext_profile,omitempty" scope:"ext_profile"`
}

// ConnectionOptionsSAML is used to configure a SAML Connection.
Expand Down Expand Up @@ -1023,8 +1025,8 @@ type ConnectionOptionsSAML struct {
AgentIP *string `json:"agentIP,omitempty"`
AgentVersion *string `json:"agentVersion,omitempty"`
AgentMode *bool `json:"agentMode,omitempty"`
ExtGroups *bool `json:"ext_groups,omitempty"`
ExtProfile *bool `json:"ext_profile,omitempty"`
ExtGroups *bool `json:"ext_groups,omitempty" scope:"ext_groups"`
ExtProfile *bool `json:"ext_profile,omitempty" scope:"ext_profile"`

SetUserAttributes *string `json:"set_user_root_attributes,omitempty"`
NonPersistentAttrs *[]string `json:"non_persistent_attrs,omitempty"`
Expand Down
8 changes: 8 additions & 0 deletions management/management.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions management/management.gen_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading