Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory JSON actions secrets matches YAML #954

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/context/directory/handlers/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ function parse(context: DirectoryContext): ParsedActions {
}

function mapSecrets(secrets) {
if (typeof secrets === 'string') {
return secrets;
}
if (secrets && secrets.length > 0) {
return secrets.map((secret) => ({ name: secret.name, value: secret.value }));
}
Expand Down
8 changes: 5 additions & 3 deletions src/context/yaml/handlers/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ async function parse(context: YAMLContext): Promise<ParsedActions> {
};
}

function mapSecrets(secrets: { name: string; value: string }[]): Secret[] {
function mapSecrets(secrets) {
if (typeof secrets === 'string') {
return secrets; //Enables keyword preservation to operate on action secrets
}
if (secrets && secrets.length > 0) {
return secrets.map((secret) => ({ name: secret.name, value: secret.value }));
}
Expand Down Expand Up @@ -86,8 +89,7 @@ async function dump(context: YAMLContext): Promise<ParsedActions> {
runtime: action.runtime,
dependencies: action.dependencies || [],
status: action.status,
secrets:
typeof action.secrets === 'string' ? action.secrets : mapSecrets(action.secrets || []), //Enables keyword preservation to operate on action secrets
secrets: mapSecrets(action.secrets),
supported_triggers: action.supported_triggers,
})),
};
Expand Down
30 changes: 30 additions & 0 deletions test/context/directory/actions.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,4 +266,34 @@ describe('#directory context actions', () => {

expect(dumpedFiles).to.have.length(0);
});

it('should process actions secrets with AUTH0_PRESERVE_KEYWORDS: true', async () => {
const dir = path.join(testDataDir, 'directory', 'test6');
const actionsDir = path.join(dir, 'actions');
cleanThenMkdir(actionsDir);

const json = `{
"name": "action-one",
"secrets": "@@SECRETS@@"
}`;
const jsonFile = path.join(actionsDir, 'action-one.json');

fs.writeFileSync(jsonFile, json);

const target = [
{
name: 'action-one',
secrets: { name: 'SECRETNAME', value: 'SECRETVALUE' }
},
];

const config = {
AUTH0_INPUT_FILE: dir,
AUTH0_KEYWORD_REPLACE_MAPPINGS: { SECRETS: { name: 'SECRETNAME', value: 'SECRETVALUE' } },
AUTH0_PRESERVE_KEYWORDS: true,
};
const context = new Context(config, mockMgmtClient());
await context.loadAssetsFromLocal();
expect(context.assets.actions).to.deep.equal(target);
});
});
Loading