Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Upgrade auth0 to v4 #852

Closed
wants to merge 9 commits into from
Closed

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Aug 31, 2023

🔧 Changes

Just a temporary PR to show what migration to v4 of auth0 would look like.

TODO

  • Add pagination overloads to clients.getAll (have updated the spec)
  • Figure out why we had to add extra PATCH /clients and DELETE /client-grants to the test fixtures (also happening for me on master)

🔬 Testing

  • Unit tests work
  • E2e tests work locally, but needs a change in node-auth0 regarding client_id (it currently takes an id instead of client_id, which we want to look into a bit more.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

src/tools/auth0/handlers/organizations.ts Show resolved Hide resolved
src/tools/auth0/handlers/pages.ts Outdated Show resolved Hide resolved
src/tools/auth0/handlers/tenant.ts Show resolved Hide resolved
src/tools/auth0/handlers/triggers.ts Show resolved Hide resolved
src/context/directory/index.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 79.52% and project coverage change: -0.78% ⚠️

Comparison is base (eb1db63) 84.23% compared to head (0811df7) 83.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
- Coverage   84.23%   83.46%   -0.78%     
==========================================
  Files         115      112       -3     
  Lines        3604     3575      -29     
  Branches      697      700       +3     
==========================================
- Hits         3036     2984      -52     
- Misses        324      341      +17     
- Partials      244      250       +6     
Files Changed Coverage Δ
src/context/directory/handlers/index.ts 100.00% <ø> (ø)
src/context/directory/handlers/resourceServers.ts 35.00% <ø> (ø)
src/context/directory/index.ts 90.47% <ø> (ø)
src/context/yaml/handlers/guardianPolicies.ts 100.00% <ø> (ø)
src/context/yaml/handlers/index.ts 100.00% <ø> (ø)
src/context/yaml/handlers/resourceServers.ts 100.00% <ø> (ø)
src/tools/auth0/client.ts 60.93% <ø> (-3.13%) ⬇️
src/tools/auth0/handlers/attackProtection.ts 72.00% <ø> (ø)
src/tools/auth0/handlers/index.ts 100.00% <ø> (ø)
src/tools/constants.ts 100.00% <ø> (ø)
... and 30 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamjmcgrath
Copy link
Contributor

Noticed one issue when running e2e tests against a live tenant (using wild mode) and raised SDK-4548

@willvedd willvedd deleted the chore/bump-auth0 branch December 4, 2023 12:35
@willvedd
Copy link
Contributor

willvedd commented Feb 2, 2024

Keeping this PR closed but restoring the original branch.

@willvedd willvedd restored the chore/bump-auth0 branch February 2, 2024 20:48
@willvedd willvedd mentioned this pull request Feb 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants