User search pagination fixed #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnmclean
suggested changes
Sep 5, 2018
There was a problem hiding this comment.
@zxan1285 could some tests be added for handleUsersPageChange to check that its making the right action call with those query/filter params?
shawnmclean
approved these changes
Dec 3, 2018
|
@zxan1285 do you recall any reason that this wasn't merged? |
Nope. I guess we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Bug described in #226
handleUsersPageChangefunction was simply ignore search params. Fixed by adding those params.This is UI change. Server side (bundle.js) is not affected by these changes.
🔗 References
Github issue: #226
🎯 Testing
✅ This change has been tested locally
✅ This change has been tested in a Webtask
✅ This change has unit test coverage
🚫 This change has integration test coverage
🚫 This change has been tested for performance