fix: Added ext-mbstring to composer.json dependencies #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Spriggs <[email protected]>
jasonspriggs
temporarily deployed
to
external
GitHub Actions
Inactive
jasonspriggs
temporarily deployed
to
external
GitHub Actions
Inactive
jasonspriggs
temporarily deployed
to
external
GitHub Actions
Inactive
evansims
approved these changes
Sep 25, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1327 1327
===========================================
Files 62 62
Lines 4613 4613
===========================================
Hits 4613 4613
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks, @jasonspriggs! |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
### Added - Support `initiate_login_uri` property for `PATCH` requests to the `/api/v2/clients/:id` Management API endpoint. [#732](#732) ### Fixed - Token generator typo in claim header. [#729](#729) ### Changed - `composer.json` now identifies `mbstring` as a required extension. [#730](#730) - PHP 8.3 nightlies have been added to the continuous integration testing matrix. [#733](#733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added ext-mbstring to composer.json dependencies. Some systems, such as Heroku, require PHP extension dependencies to be specified in composer.json. This pull request resolves that dependency.
References
auth0/symfony#155 (comment)
Testing
Contributor Checklist