Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO dashboard to run on node 18 #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

julienwoll
Copy link

@julienwoll julienwoll commented Sep 21, 2023

✏️ Changes

Moving to webtask environment on node 18. Requires an update of auth0 extension tools and peer dependencies.

🎯 Testing

  • Test the app as a admin: Create 2 applications, use them to authenticate. Logout. Change the settings of one app. Try the app again. Try to filter the apps in the application screen.
  • Test the app as a user: Use the 2 applications, logout.
  • Try the hooks: oninstall, onupdate, onuninstall.

🚫 This change has been tested in a Webtask WORK IN PROGRESS

✅ This change has unit test coverage

✅ This change has integration test coverage

🚫 This change has been tested for performance

🚀 Deployment

✅ This can be deployed any time

🎡 Rollout

In order to verify that the deployment was successful we will deploy the extension and test it thoroughly on node 12, 16. and 18.

🔥 Rollback

In case of any malfunctioning of the application.

📄 Procedure

Re-deploy the previous version 2.4.1. Downgrade node version to 12.

@julienwoll julienwoll self-assigned this Sep 21, 2023
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 43215 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Sep 22, 2023

Code Climate has analyzed commit 75bd8a0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.9% (0.0% change).

View more on Code Climate.

@julienwoll julienwoll force-pushed the sso-dashboard-node-18 branch from 70cfdd3 to ba7f983 Compare September 22, 2023 11:49
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 43857 lines exceeds the maximum allowed for the inline comments feature.

@julienwoll julienwoll force-pushed the sso-dashboard-node-18 branch from 7c0db02 to 75bd8a0 Compare September 22, 2023 15:47
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 44158 lines exceeds the maximum allowed for the inline comments feature.

@@ -1,8 +1,8 @@
{
"title": "SSO Dashboard",
"name": "auth0-sso-dashboard",
"version": "2.4.1",
"preVersion": "2.2.1",
"version": "2.4.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before releasing we should discuss whether to use a minor or patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants