Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IDS-5149] Node18 upgrade #304

Merged
merged 37 commits into from
Dec 11, 2024
Merged

feat: [IDS-5149] Node18 upgrade #304

merged 37 commits into from
Dec 11, 2024

Conversation

sauntimo
Copy link
Contributor

@sauntimo sauntimo commented Oct 31, 2024

✏️ Changes

Update DAE dependencies and get running in node18

📷 Screenshots

[DAE Extension] node 18 upgrade - manual testing report

🔗 References

https://auth0team.atlassian.net/browse/IDS-5149

🎯 Testing

Monika's Manual tests:
[DAE Extension] node 18 upgrade - manual testing report

Fede's manual tests:

  • Exploratory testing comparing DAE logs and webtask logs to baseline.

Logs page:

  • Refresh logs (and not get new Client Credential logs every time)
  • Load more logs
  • See various generated logs: login, signup, enroll in MFA, unenroll

Users page:

  • Search users by name
  • Search users by email with wildcard
  • Reset search
  • Create user
  • Order by Latest login and Logins (asc and desc)

User page:

  • Display same user info as baseline
  • Enroll user in MFA through manage dashboard and see the added MFA field
  • Verify email and see EMAIL_VERIFIED: TRUE
  • Actions: Block
  • Actions: Unblock
  • Actions: Unenroll MFA
  • Actions: Re-send verification email
  • Actions: Reset password
  • Actions: Change email
  • Actions: Change Password
  • Actions: Delete User
  • Devices tab shows devices
  • Logs tab shows user related logs
  • Clicking on a log shows more details
  • Profile tab shows user JSON payload

Configuration page:

  • Filter hook can be created to filter shown users with a lucene query email:dae*
  • Filter hook can be cleared
  • Access Hook can be created to disallow deleting users
  • Access Hook can be cleared
  • Write hook can be created to add some metadata to all created users
  • Write hook can be cleared
  • Membership hook can be created to enable membership selection and define an array of memberships. Dropdown shows in user creation dialog
  • Membership hook can be cleared
  • Settings query hook can be created which limits connections to manage, change UI strings with "dict", load a css sheet, limit whether the user can create users, change labels for form fields and add text localization
  • Settings query hook can be cleared

All the above was tested with an admin user.

Other roles:

  • User role can do everything the admin can do except access the logs and configuration pages
  • Operator role can do everything the admin can do except access the configuration page
  • Auditor role can only search for users and get user information

✅ This change has been tested in a Webtask

✅ This change has unit test coverage

✅ This change has integration test coverage

🚫 This change has been tested for performance

🚀 Deployment

✅ This can be deployed any time

🎡 Rollout

In order to verify that the deployment was successful we will test the new version of the extension in production with no extension gallery overrides.

🔥 Rollback

We will rollback if there are any issues with the extension

📄 Procedure

The extensions.json will be modified so the latest version of the extension is the previous one (4.4). Customers with issues will be instructed to downgrade.

🖥 Appliance

Note to reviewers: ensure that this change is compatible with the Appliance.

@Monika-Khviasko Monika-Khviasko changed the title [WIP] Node18 upgrade feat: [IDS-5149] Node18 upgrade Nov 8, 2024
@Monika-Khviasko Monika-Khviasko force-pushed the node18-upgrade branch 2 times, most recently from 41c291d to 203d02f Compare November 8, 2024 09:14
clientSecret: config("AUTH0_CLIENT_SECRET"),
};

const isAdministrator =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Monika-Khviasko Monika-Khviasko force-pushed the node18-upgrade branch 8 times, most recently from 8a69199 to c5444bb Compare November 8, 2024 11:31
@Monika-Khviasko Monika-Khviasko marked this pull request as ready for review November 8, 2024 11:31
@sauntimo
Copy link
Contributor Author

I've reviewed the code and it looks good and tested the functionality in a prod tenant and it seems to be working as expected. I'm not leaving a formal review as I contributed code to the PR.

Copy link
Contributor

@VictorGarridoAuth0 VictorGarridoAuth0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbgoode fbgoode merged commit a77fc69 into master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants