-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IDS-5149] Node18 upgrade #304
Conversation
41c291d
to
203d02f
Compare
clientSecret: config("AUTH0_CLIENT_SECRET"), | ||
}; | ||
|
||
const isAdministrator = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8a69199
to
c5444bb
Compare
56a46f9
to
8a8eb7b
Compare
778bc18
to
09ab24d
Compare
a03bd53
to
edb91e4
Compare
I've reviewed the code and it looks good and tested the functionality in a prod tenant and it seems to be working as expected. I'm not leaving a formal review as I contributed code to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✏️ Changes
Update DAE dependencies and get running in node18
📷 Screenshots
[DAE Extension] node 18 upgrade - manual testing report
🔗 References
https://auth0team.atlassian.net/browse/IDS-5149
🎯 Testing
Monika's Manual tests:
[DAE Extension] node 18 upgrade - manual testing report
Fede's manual tests:
Logs page:
Users page:
User page:
Configuration page:
All the above was tested with an admin user.
Other roles:
✅ This change has been tested in a Webtask
✅ This change has unit test coverage
✅ This change has integration test coverage
🚫 This change has been tested for performance
🚀 Deployment
✅ This can be deployed any time
🎡 Rollout
In order to verify that the deployment was successful we will test the new version of the extension in production with no extension gallery overrides.
🔥 Rollback
We will rollback if there are any issues with the extension
📄 Procedure
The extensions.json will be modified so the latest version of the extension is the previous one (4.4). Customers with issues will be instructed to downgrade.
🖥 Appliance
Note to reviewers: ensure that this change is compatible with the Appliance.