Add more filters, order bys to the report, also bump version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add link to view mailing to the id field (& make it mailing_id not stats mailing_id in case deleted. I would have linked to add class crm-hover to that to make it pop-up viewable but didn't spend long enough to determine if report frameworksupports yet
wmfgerrit
pushed a commit
to wikimedia/wikimedia-fundraising-crm
that referenced
this pull request
Jul 26, 2017
Primary goal here is to add an order by to received date on the mailing report here civicrm/report/instance/99?reset=1&force=1 so Caitlin can better review, use it. As a byproduct added a bunch more order bys & filters & a link to view mailing text Upstream PR australiangreens/au.org.greens.extendedmailingstats#3 Bug: T161758 Change-Id: I04fff923322e23586d222dfe582cdbfafe61876d
The MailingStats folder is not being used. I checked & even the files in this path refer to the ExendedMailingStats folder so I think it can just go
|
@seamuslee001 just added another commit in here :-) |
|
Just added a boilerplate update |
|
just ran the civix upgrade |
the construct is deprecated
|
@johntwyman I realise this is only marginally maintained but I just investigated a deprecation warning & fixed it |
|
Thanks @eileenmcnaughton! |
|
@johntwyman this might win longest running PR ever - I just added another update -7 years after the first one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seamuslee001 ...