Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python packages #345

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Upgrade python packages #345

merged 2 commits into from
Dec 9, 2024

Conversation

chiphogg
Copy link
Contributor

@chiphogg chiphogg commented Dec 8, 2024

This fixes dependabot alerts 11, 12, and 13. Granted, dependabot is
generally pretty meaningless for our use case, but (a) it's nice to get
back to a clean state, and (b) it's a good reminder to update our python
packages periodically.

I read the release notes for mike, mkdocs, and mkdocs-material. The
former two had only bugfixes. The latter had a new version of mermaid,
so I made sure to include pages that used mermaid diagrams in my A/B
blink comparisons. It looks like it switched the order and changed the
sizes some, but the diagrams are equivalent and both are fine.

Before:

image

After:

image

Other than this, I really didn't see any difference at all in the A/B
comparison.

I also checked mike according to the instructions in
REQUIREMENTS_LOCK.md. Still works!

This fixes dependabot alerts 11, 12, and 13.  Granted, dependabot is
generally pretty meaningless for our use case, but (a) it's nice to get
back to a clean state, and (b) it's a good reminder to update our python
packages periodically.

I read the release notes for mike, mkdocs, and mkdocs-material.  The
former two had only bugfixes.  The latter had a new version of mermaid,
so I made sure to include pages that used mermaid diagrams in my A/B
blink comparisons.  It looks like it switched the order and changed the
sizes some, but the diagrams are equivalent and both are fine.

Before:

![image](https://github.com/user-attachments/assets/e38c4e39-c112-40ff-8e8c-a2d6cbe2445f)

After:

![image](https://github.com/user-attachments/assets/8eb99d0c-64ed-4696-8c86-e09d094aea0f)

Other than this, I really didn't see any difference at all in the A/B
comparison.

I also checked `mike` according to the instructions in
`REQUIREMENTS_LOCK.md`.  Still works!
@chiphogg chiphogg requested a review from geoffviola December 8, 2024 20:59
@chiphogg chiphogg merged commit c3480e8 into main Dec 9, 2024
13 checks passed
@chiphogg chiphogg deleted the chiphogg/dependabot-11-12-13 branch December 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants