Replace integer_quotient with unblock_int_div
#315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `integer_quotient(a, b)`, we now always write `a / unblock_int_div(b)`. This gives us everything we used to have with `integer_quotient`, but with two big advantages: 1. The form for the units code becomes more similar to the non-units code that it replaces (i.e., we're using the `/` symbol). 2. We can now support _templated code_ that works for both integral and non-integral types: `a / unblock_int_div(b)` works equally well for, say, `b` with floating point rep. There's no longer any use case for `integer_quotient`. We therefore immediately deprecate it. We will keep it deprecated for the entirety of the 0.4.0 cycle, and remove it for 0.5.0. Fixes #253.
chiphogg
added
release notes: ✨ lib (enhancement)
geoffviola
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
integer_quotient(a, b), we now always writea / unblock_int_div(b). This gives us everything we used to have withinteger_quotient, but with two big advantages:The form for the units code becomes more similar to the non-units
code that it replaces (i.e., we're using the
/symbol).We can now support templated code that works for both integral and
non-integral types:
a / unblock_int_div(b)works equally well for,say,
bwith floating point rep.There's no longer any use case for
integer_quotient. We thereforeimmediately deprecate it. We will keep it deprecated for the entirety
of the 0.4.0 cycle, and remove it for 0.5.0.
Fixes #253.