Test options in CMake CI jobs #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we only run one CMake configuration in CI. It's the default one, where we permit the GTest dependency, and we build and run tests. Now we are adding two more configurations, one for each of the new options: - Set `AU_ENABLE_TESTING` to `FALSE` - Set `AU_EXCLUDE_GTEST_DEPENDENCY` to `TRUE` (implies the former) In both these instances, the `test` target won't exist, so we exclude it from running. We do however retain the `CMAKE_VERIFY_INTERFACE_HEADER_SETS` option, because that gives us useful testing for our interface targets. Fixes #304.
chiphogg
added
the
release notes: ⚙️ repo
We will revert before landing. But we want to show that the new jobs would catch things like this.
This reverts commit 01321e3. It served its purpose: we know the CI jobs work!
|
@timhirsh, see this failed build. Note that evidently, when one matrix build fails, it cancels the others. This seems OK, since they all need to be passing all the time. |
|
Now instead of getting 11 notifications from the GitHub app, every time I make, update, or land a PR... I can get 13! 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only run one CMake configuration in CI. It's the default
one, where we permit the GTest dependency, and we build and run tests.
Now we are adding two more configurations, one for each of the new
options:
AU_ENABLE_TESTINGtoFALSEAU_EXCLUDE_GTEST_DEPENDENCYtoTRUE(implies the former)In both these instances, the
testtarget won't exist, so we exclude itfrom running.
We do however retain the
CMAKE_VERIFY_INTERFACE_HEADER_SETSoption,because that gives us useful testing for our interface targets.
Fixes #304.