Fetch gcc toolchain from archive/ URL
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using the `tarball/` URL, which includes both the organization and the repo name as part of the prefix. GitHub also has an `archive/` URL format which, according to this [comment], only includes the repo name, not the organization! This PR switches to the new format, making us less vulnerable to build breakage if the repo changes homes again. (Notice how `f0rmiga` never appears except in the URL --- in particular, it is now absent from `strip_prefix`.) The even better solution would be to download stable tarballs from the release page, but the project has not yet begun to provide those. [comment]: f0rmiga/gcc-toolchain#165 (comment)
chiphogg
added
the
release notes: ⚙️ repo
geoffviola
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using the
tarball/URL, which includes both theorganization and the repo name as part of the prefix. GitHub also has
an
archive/URL format which, according to this comment, onlyincludes the repo name, not the organization!
This PR switches to the new format, making us less vulnerable to build
breakage if the repo changes homes again. (Notice how
f0rmiganeverappears except in the URL --- in particular, it is now absent from
strip_prefix.) The even better solution would be to download stabletarballs from the release page, but the project has not yet begun to
provide those.