Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake CI tests for different options #304

Closed
chiphogg opened this issue Oct 21, 2024 · 0 comments · Fixed by #313
Closed

Add CMake CI tests for different options #304

chiphogg opened this issue Oct 21, 2024 · 0 comments · Fixed by #313
Labels
⬇️ affects: repo or tools Affects the non-library tools or the repository itself 📁 kind: bug Something isn't working correctly, or there's a mistake 💪 effort: small
Milestone
0.4.0

Comments

@chiphogg
Copy link
Contributor

In #303, we added a new option to skip tests, but had no automated CI builds/tests to make sure the option worked. We need to enhance our CMake CI job to run with this configuration.
@chiphogg chiphogg added 📁 kind: bug Something isn't working correctly, or there's a mistake 💪 effort: small ⬇️ affects: repo or tools Affects the non-library tools or the repository itself labels Oct 21, 2024
@chiphogg chiphogg mentioned this issue Oct 21, 2024
Merged
@chiphogg chiphogg added this to the 0.4.0 milestone Oct 25, 2024
chiphogg added a commit that referenced this issue Oct 28, 2024
@chiphogg
Test options in CMake CI jobs
7d0442e 
Currently, we only run one CMake configuration in CI.  It's the default
one, where we permit the GTest dependency, and we build and run tests.
Now we are adding two more configurations, one for each of the new
options:

- Set `AU_ENABLE_TESTING` to `FALSE`
- Set `AU_EXCLUDE_GTEST_DEPENDENCY` to `TRUE` (implies the former)

In both these instances, the `test` target won't exist, so we exclude it
from running.

We do however retain the `CMAKE_VERIFY_INTERFACE_HEADER_SETS` option,
because that gives us useful testing for our interface targets.

Fixes #304.
@chiphogg chiphogg mentioned this issue Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⬇️ affects: repo or tools Affects the non-library tools or the repository itself 📁 kind: bug Something isn't working correctly, or there's a mistake 💪 effort: small
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Test options in CMake CI jobs aurora-opensource/au
1 participant
@chiphogg