Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: removed toolchain dependency and set near-sandbox for tests directly in CI. #36

Closed
wants to merge 3 commits into from

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Sep 20, 2023

Description

Removed toolchain dependency and set near-sandbox for tests directly in CI.

@mrLSD mrLSD self-assigned this Sep 20, 2023
@mrLSD mrLSD added the enhancement New feature or request label Sep 20, 2023
@mrLSD mrLSD added this to the v0.3.2 milestone Sep 20, 2023
@mrLSD mrLSD changed the title Feat: set stable toolchain Feat: removed toolchain dependency and set near-sandbox for tests directly in CI. Sep 20, 2023
@mrLSD mrLSD requested a review from aleksuss September 20, 2023 19:51
Copy link
Member

@aleksuss aleksuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the near-workspaces as well.

@mrLSD
Copy link
Member Author

mrLSD commented Nov 6, 2023

Bump the near-workspaces as well.

I think it's out of scope for this PR.

@aleksuss
Copy link
Member

aleksuss commented Nov 6, 2023

By bumping near-workspaces you don't need to add this:

- name: Install sandbox
         run: |
           if [[ ! -f ${{ env.NEAR_SANDBOX_BIN_PATH }} ]]; then
             rm -rf nearcore
             git clone --depth 1 --branch 1.35.0 https://github.com/near/nearcore
             cd nearcore
             make sandbox-release
             cp target/release/near-sandbox $HOME/bin/
             cache-util save sandbox:${{ env.NEAR_SANDBOX_BIN_PATH }}          
             cd ../
             rm -rf nearcore
           fi

@mrLSD mrLSD modified the milestones: v0.3.2, v0.4.0 Nov 7, 2023
@mrLSD
Copy link
Member Author

mrLSD commented Nov 7, 2023

Fully resolved in #37

@mrLSD mrLSD closed this Nov 7, 2023
@mrLSD mrLSD deleted the feat/set-stable-toolchain branch November 7, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants