Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed namespace missing in _async_fetch_metadata inside Pinecone #490

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix: Fixed namespace missing in _async_fetch_metadata inside Pinecone #490

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1486079
Fixed namespace missing in _async_fetch_metadata inside Pinecone
Vits-99 Dec 17, 2024
6320f6d
Linting
Vits-99 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions semantic_router/index/pinecone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,9 @@
"ids": [vector_id],
}

if self.namespace:
params["namespace"] = self.namespace

Check warning on line 657 in semantic_router/index/pinecone.py

View check run for this annotation

Codecov / codecov/patch

semantic_router/index/pinecone.py#L656-L657 

Added lines #L656 - L657 were not covered by tests

headers = {
"Api-Key": self.api_key,
}
Expand Down
Loading