Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 313 testing and upgrade pydantic #472

Merged
merged 13 commits into from
Dec 1, 2024
Merged

Conversation

jamescalam
Copy link
Member

@jamescalam jamescalam commented Nov 30, 2024

PR Type

Adds Python 3.13 support and tests. Also includes pydantic updates. Closes #452


Description

  • Updated Python version to 3.13 across various workflow configurations and files.
  • Updated Poetry version to 1.8.4 in workflows.
  • Added Python 3.13 to the testing matrix.
  • Updated the default Python version in pre-commit configuration.
  • Updated the Python version range in pyproject.toml and added a constraint for the fastembed dependency.
  • Updated the copyright year in the LICENSE file.

Changes walkthrough 📝

Relevant files
Configuration changes
9 files
docs.yml
Update Python and Poetry versions in docs workflow             

.github/workflows/docs.yml

  • Updated Python version from 3.11 to 3.13.
  • Updated Poetry version from 1.8.3 to 1.8.4.
  • +2/-2     
    lint.yml
    Update Python and Poetry versions in lint workflow             

    .github/workflows/lint.yml

  • Updated Python version from 3.11 to 3.13.
  • Updated Poetry version from 1.5.1 to 1.8.4.
  • +2/-2     
    release.yml
    Update Python and Poetry versions in release workflow       

    .github/workflows/release.yml

  • Updated Python version from 3.11 to 3.13.
  • Updated Poetry version from 1.5.1 to 1.8.4.
  • +3/-3     
    test.yml
    Add Python 3.13 to test matrix and update Poetry                 

    .github/workflows/test.yml

  • Added Python 3.13 to the testing matrix.
  • Updated Poetry version from 1.5.1 to 1.8.4.
  • +2/-1     
    .pre-commit-config.yaml
    Update default Python version in pre-commit config             

    .pre-commit-config.yaml

    • Changed default Python version to 3.13.
    +1/-1     
    .python-version
    Update Python version file                                                             

    .python-version

    • Updated Python version from 3.11 to 3.13.
    +1/-1     
    .readthedocs.yaml
    Update Python version in Read the Docs config                       

    .readthedocs.yaml

    • Updated Python version from 3.12 to 3.13.
    +1/-1     
    Makefile
    Update target Python version in Makefile                                 

    Makefile

    • Updated target Python version to 3.13 for formatting and linting.
    +2/-2     
    pyproject.toml
    Update Python version range and dependencies                         

    pyproject.toml

  • Updated Python version range to include 3.13.
  • Added Python version constraint for fastembed dependency.
  • +2/-2     
    Miscellaneous
    1 files
    LICENSE
    Update copyright year                                                                       

    LICENSE

    • Updated copyright year to 2024.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @jamescalam jamescalam self-assigned this Nov 30, 2024
    @jamescalam jamescalam added the feature New feature request label Nov 30, 2024
    @jamescalam jamescalam changed the title feat: add 313 testing feat: add 313 testing and upgrade pydantic Dec 1, 2024
    Copy link

    codecov bot commented Dec 1, 2024

    Codecov Report

    Attention: Patch coverage is 89.70588% with 7 lines in your changes missing coverage. Please review.

    Project coverage is 73.47%. Comparing base (ff2c3ca) to head (fb1544d).
    Report is 15 commits behind head on main.

    Files with missing lines Patch % Lines
    semantic_router/encoders/clip.py 33.33% 2 Missing ⚠️
    semantic_router/index/postgres.py 0.00% 2 Missing ⚠️
    semantic_router/llms/openai.py 77.77% 2 Missing ⚠️
    semantic_router/encoders/huggingface.py 80.00% 1 Missing ⚠️
    Additional details and impacted files
    @@            Coverage Diff             @@
    ##             main     #472      +/-   ##
    ==========================================
    - Coverage   73.61%   73.47%   -0.15%     
    ==========================================
      Files          43       43              
      Lines        3548     3540       -8     
    ==========================================
    - Hits         2612     2601      -11     
    - Misses        936      939       +3     

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    @jamescalam jamescalam merged commit 77539cf into main Dec 1, 2024
    10 checks passed
    @jamescalam jamescalam deleted the james/py313-support branch December 1, 2024 15:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Python 3.12-3.13 support?
    1 participant