Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remote duplicate testing on pr merge #462

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

jamescalam
Copy link
Member

@jamescalam jamescalam commented Nov 16, 2024

PR Type

configuration changes


Description

  • Removed the duplicate testing trigger for push events to the main branch in the GitHub Actions workflow configuration.
  • Ensured that testing is still triggered on pull requests to maintain CI/CD integrity.

Changes walkthrough 📝

Relevant files
Configuration changes
test.yml
Remove duplicate testing trigger on push events                   

.github/workflows/test.yml

  • Removed duplicate testing trigger on push to the main branch.
  • Retained testing trigger on pull requests.
  • +0/-3     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @jamescalam jamescalam merged commit 43c2015 into main Nov 16, 2024
    6 checks passed
    @jamescalam jamescalam deleted the james/drop-duplicate-testing branch November 16, 2024 17:01
    Copy link

    codecov bot commented Nov 16, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 72.09%. Comparing base (06e3a6a) to head (b524a61).
    Report is 2 commits behind head on main.

    Additional details and impacted files
    @@           Coverage Diff           @@
    ##             main     #462   +/-   ##
    =======================================
      Coverage   72.09%   72.09%           
    =======================================
      Files          39       39           
      Lines        3290     3290           
    =======================================
      Hits         2372     2372           
      Misses        918      918           

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant