-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented aget_routes async method for pinecone index #397
Merged
jamescalam
merged 13 commits into
main
from
vittorio/add-async-get-routes-method-to-pinecone-index
Aug 23, 2024
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
748780c
Implemented aget_routes async method for pinecone index
Vits-99 15560be
Update semantic_router/index/pinecone.py
jamescalam 4c8020d
Update semantic_router/index/pinecone.py
jamescalam a22b1d1
Update semantic_router/index/pinecone.py
jamescalam 9ab0ff9
Update semantic_router/index/pinecone.py
jamescalam 682e7f1
Update semantic_router/index/pinecone.py
jamescalam 32f72c9
Update semantic_router/index/pinecone.py
jamescalam f9c6e0f
chore: lint
jamescalam 615bcdb
chore: black lint
jamescalam e2668a8
fix: types
jamescalam 6a4bd38
chore: upgrade version
jamescalam 5cdf1d2
fix: vit test condition fix
jamescalam 7f2cfae
fix: tests
jamescalam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't use these type annotations as we need to remain backwards compatible with python 3.9, should instead use
Optional[str] = None
in this case