Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openai version to ^1.0.0 #26

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Bump openai version to ^1.0.0 #26

merged 2 commits into from
Dec 14, 2023

Conversation

simjak
Copy link
Member

@simjak simjak commented Dec 13, 2023

Link to the issue #23

@simjak simjak added the enhancement Enhancement to existing features label Dec 13, 2023
@simjak simjak self-assigned this Dec 13, 2023
@simjak simjak linked an issue Dec 13, 2023 that may be closed by this pull request
@jamescalam
Copy link
Member

Should we bump up to 1.3.9? https://pypi.org/project/openai/

Also it seems the change has caused the tests to fail

Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@simjak
Copy link
Member Author

simjak commented Dec 14, 2023

I don't want enforce other to use the latest version, but we can bump to the latest and see if we have complains

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4ffbb8) 100.00% compared to head (3fd56d1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          334       344   +10     
=========================================
+ Hits           334       344   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simjak simjak merged commit 6a0001d into main Dec 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update openai SDK to the latest version
2 participants