Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decorators for validations #524

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

iuribrindeiro
Copy link

Creating decorators for aurelia validation

@CLAassistant
Copy link

CLAassistant commented May 12, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iuribrindeiro
❌ Iuri


Iuri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iuribrindeiro iuribrindeiro force-pushed the develop branch 3 times, most recently from 2cf89e2 to ef804cb Compare May 12, 2019 18:47
@iuribrindeiro
Copy link
Author

@EisenbergEffect can you take a look at this?

@bigopon
Copy link
Member

bigopon commented May 13, 2019

pinging @jdanyow

For me, it looks good, maybe add some tests and we can see what's missing/edge cases

@iuribrindeiro
Copy link
Author

iuribrindeiro commented May 13, 2019

pinging @jdanyow

For me, it looks good, maybe add some tests and we can see what's missing/edge cases

Awesome! Can I add the tests myself? Or you guys should do it?

@bigopon
Copy link
Member

bigopon commented May 13, 2019

@iuribrindeiro normally the PR author helps with some tests, it would help clarify the logic the author has in mind when doing the PR best.

@iuribrindeiro
Copy link
Author

@iuribrindeiro normally the PR author helps with some tests, it would help clarify the logic the author has in mind when doing the PR best.

Ok, so I'm gonna add some tests latter :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants