-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decorators for validations #524
base: develop
Are you sure you want to change the base?
Conversation
Iuri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
2cf89e2
to
ef804cb
Compare
@EisenbergEffect can you take a look at this? |
pinging @jdanyow For me, it looks good, maybe add some tests and we can see what's missing/edge cases |
Awesome! Can I add the tests myself? Or you guys should do it? |
@iuribrindeiro normally the PR author helps with some tests, it would help clarify the logic the author has in mind when doing the PR best. |
Ok, so I'm gonna add some tests latter :) |
Creating decorators for aurelia validation