Merge pull request #593 from bigopon/fix-child-children-deco

fix(child-observation): unset property in unbind
aurelia · Jun 20, 2018 · 926f6e5 · 926f6e5
2 parents 5d0f0c1 + 7989015
commit 926f6e5
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/child-observation.js b/src/child-observation.js
@@ -178,7 +178,9 @@ class ChildObserverBinder {
         if (!items) {
           items = viewModel[this.property] = [];
         } else {
-          items.length = 0;
+          // The existing array may alread be observed in other bindings
+          // Setting length to 0 will not work properly, unless we intercept it
+          items.splice(0);
         }
 
         while (current) {
@@ -273,6 +275,7 @@ class ChildObserverBinder {
     if (this.viewHost.__childObserver__) {
       this.viewHost.__childObserver__.disconnect();
       this.viewHost.__childObserver__ = null;
+      this.viewModel[this.property] = null;
     }
   }
 }