Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way better code coverage badge #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AshleyGrant
Copy link

The best part is this badge guarantees you will always have full code coverage.

@AshleyGrant
Copy link
Author

As you can see, this is far superior.

image

@zewa666
Copy link
Member

zewa666 commented May 31, 2018

I see the point of the always-full-coverage feature. But let's be honest ... this is just a bold statement. Do you have a test as proof this will stay that way?

@AshleyGrant
Copy link
Author

It's written right there in black and green. That's all the proof you need. Anybody who says otherwise is fake news.

@AshleyGrant
Copy link
Author

Green is the universal color that represents GO! So the badge being green means the test coverage is good to GO!

@Vheissu
Copy link
Member

Vheissu commented May 31, 2018

We need this merged, please. It is blocking me and I really need this badge merged in to convince everyone how great the test coverage is for this plugin. thx

@zewa666
Copy link
Member

zewa666 commented Sep 25, 2018

@AshleyGrant and @Vheissu here is a potential alternative. https://github.com/auchenberg/volkswagen
Not only containing a nice evergreen badge but it makes all our tests suddenly go green. The best of it, its backed by a large corp, so it has to be awesome right?

@AshleyGrant
Copy link
Author

I am completely in favor of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants